calendar

7.4 KB

1. # Report 001 (w085): calendar code order, no behaviour change
3. **Where:** commits on main in loreana:/media/STORAGE/projects/calendar.worldapi.org (parent d6c5929):
4. - `c6fbd01`: file moves (1/4)
5. - `f5ce6b1`: topics, map and thin faces (2/4)
6. - `3b2a4cd`: `let` (3/4)
7. - the docs + tests commit (4/4), which also holds this report and the mission brief
9. Not pushed, not deployed. No `.env` read. Only ports 8760–8764 and 8767–8769 were used (8765/8766 skipped). Every server was stopped by its PID; nothing of mine is still running. This ran after notes mission 002, in the same session.
11. ## Counts (before → after; `python3 tests/letcount.py .`, which now also scans sub-folders)
13. | | before (d6c5929) | after |
14. |---|---|---|
15. | `.hl` files in the root | 4 | **1** (project.hl) |
16. | project.hl lines | 107 | **65** (index comment, PWA config, routes, audience, server) |
17. | `let` total | 256 | 110 |
18. | `let` never reassigned | **147** (52 of them in components/month-view/month-view.hl) | **0** |
20. The 110 `let`s left are all needed:
21. - 67 are reassigned;
22. - 43 are re-bound in a loop body (hybriel#128).
24. ## Layout
26. The full file map is in README "Layout". Imports only go one way: util ← users, settings, events-helpers ← events ← api-helpers ← api ← project.hl.
28. - **`lib/events.hl`**: the table and every write to it.
29. - Holds `saveEvent`, `createEvent`, `changeEvent`, `deleteEvent`, `eventsBetween` and `upcoming`.
30. - `soonOf` is here now (before, it was in the calendar component).
31. - The faces' answers are `calendarView` and `settingsView`. Before, all five faces built the same object of four calls themselves.
32. - **`lib/events-helpers.hl`**: `build`, `viewOf`, `isLocalId`, `validWindow` (out of the component), the size limits, and `byStart` (the hand sort that was inside `eventsBetween`).
33. - **`lib/settings.hl`**: the settings table and the default reminders: `settingsOf`, `defaultsOf`, `saveDefaults`. Before, these were in events.hl.
34. - **`lib/users.hl`**: users and ident.
35. - `userOfLoginCode` is new here: the single exchange + `ensureUser` step. Before, the login route and the `calendarLogin` face each had their own copy.
36. - `tagOf` moved here out of project.hl.
37. - **`lib/api.hl`**: `/login/callback` and `loginFailed` (this was `failed`). Both take `&req` and `&sessions`.
38. - **`lib/api-helpers.hl`**: `safePath`.
39. - **`lib/util.hl`**: `envOr`, `storageDir`, `countOfList`, `firstOf`, `isHex`, `isIdentId`. Before, these were in users.hl.
40. - **Moved:** `styles.hl` → `components/styles.hl`. `tools/migrate-short-ids.hl` now imports from `lib/`.
41. - **`components/month-view/` stays as it is.** It is the vendored month view, extended here, with its own README. Its `dates.hl`, `reminders.hl` and `clock.hl` are shared with the server. Only its imports changed, and its `let`s.
42. - **Faces made thin:**
43. - `calLoad`, `calSave`, `calDelete`, `calSettingsLoad`, `calSettingsSave`, `calSaveQueued`: check the session and the input, call `lib/`, answer;
44. - `calendarLogin` → `userOfLoginCode`. The session writes stay in the face.
46. ## Tests
48. | test | result |
49. |---|---|
50. | gate `tests/browser.mjs` (app 8760, ident 8761, Chrome 8767–8769) | **78 passed, 0 failed** before and after steps 1 and 2. After step 3: 3 of 4 runs 78/0; 1 run 36/1 |
51. | `tests/short-id-switch.mjs` (8760/8761) | **18/0** before and after each step |
52. | live-data reads + writes | identical, except **the intended differences** (below) |
54. **The failed gate run:** it timed out on "next month". That is the known flake on a loaded machine (STATUS 2026-09-26). The three re-runs were green, and the live-data run covers paging through `calLoad`.
56. **Live-data comparison** (new `tests/realdata-baseline.mjs` and `tests/realdata-compare.py`; how to run: README "Run, test, deploy" → "Same output"):
57. - **Data:** a copy of Byrodin's `storage/mpackdb`: 1 user, 6 events, no settings row.
58. - **Ident:** a fake ident on port + 5.
59. - **Reads** (53):
60. - `/` signed in, signed out, and in de and fr;
61. - `/login/failed`, the static files, the manifest, `/__hl/sw.js` and the browser modules;
62. - `calLoad` for all events and for every month that has one, plus 5 other or bad windows, and signed out;
63. - `calSettingsLoad`;
64. - `/login/callback` failing six ways, with and without a session.
65. - **Writes** (69):
66. - creating an appointment, an all-day event over three days, a one-day event, an overnight event in Tokyo, own reminders, and none;
67. - 18 field refusals;
68. - not an object, a bad window, signed out;
69. - an edit;
70. - the offline queue (`calSaveQueued` with a `local-` id, again, then an edit and a delete with that id);
71. - deletes: again, unknown, null, bad window, signed out;
72. - a live event changed and deleted;
73. - the defaults saved, saved again, refused twice, refused signed out;
74. - logins through the button, with `next` values and with a session;
75. - the login face, four ways; logout;
76. - the reads that follow.
77. - **Masks:** two runs of the OLD code compare clean (122/122).
78. - What they mask: source positions, `?v=` and `hl-shell-` hashes, the request times (also double-escaped), the port in the echoed Host header, and for writes the new ids, ms stamps and login tags.
79. - The structural module check now ignores `this.x` and the component's own methods. Before, month-view's method `build` clashed with the imported `build` of events-helpers.
81. **The intended differences:**
82. 1. **The failed-login reason is kept** (3 answers, the same fix as gitoria 002 and notes 002).
83. - **What changed:** `/login/failed`, opened after a failed `/login/callback` in a browser that has a session, now shows the reason. Example: "ident refused the login (403: code expired)".
84. - **Before:** it said "the login did not finish — try again".
85. - **To undo it:** pass `req` by value to `loginFailed`.
86. 2. **The calendar component's browser module** no longer carries `validWindow` and `soonOf`. They moved to `lib/`, and only the server faces ever called them.
88. **Step 3 (`let`) against step 2:** 0 different, including every browser module.
90. **Other checks:**
91. - A server without `CALENDAR_STORAGE` still reads its own `./storage/mpackdb`: 6 events, on the old tree and the new one.
92. - In the compiled month view, every `build(…)` call is still `this.build` (checked in the module).
94. ## Found (in STATUS)
96. 1. **A plain declaration that is used AFTER its block breaks in the browser.** The browser target makes it a block-scoped `const`. `.scratch/w085/unlet.py` now keeps `let` in that case. A small test proved the check works; nothing in calendar needed it.
97. 2. **The browser module hoists the imports of every imported file as module constants.** For example `const build=$_N.build` from events-helpers sits next to month-view's own method `build`. This is harmless, because the method is called as `this.build`, but it confuses a by-name comparison.
98. 3. **The old #48 audit missed the lost `failed(req)` write.** README now notes this.
100. ## Not done / open
102. - **Not deployed** (that is the architect's job). Use the normal `./deploy.sh`. There is no data change.
103. - rsync does not delete, so the old root `events.hl`, `users.hl` and `styles.hl` stay on Byrodin. They are unused and can be removed by hand.
104. - The service worker's cache name changes with the new module hashes, as it does after any code change.
105. - **The "next month" gate flake is still open** (pre-existing).
106. - **Scratch** (gitignored) in `.scratch/w085/`:
107. - `old/`;
108. - `gates.sh`, `step.sh`, `unlet.py` (with the after-the-block check), `nostore.mjs`;
109. - the gate outputs.
110. - **Deleted after the run:** the live-data copy and every baseline output.